Skip to content

Conversation

Mantisus
Copy link
Collaborator

@Mantisus Mantisus commented Aug 8, 2025

  • bump minimum Python version to 3.10

@Mantisus Mantisus self-assigned this Aug 8, 2025
@Mantisus Mantisus marked this pull request as ready for review August 8, 2025 00:29
@Mantisus Mantisus requested review from janbuchar and Pijukatel August 8, 2025 00:29
@Mantisus Mantisus marked this pull request as draft August 8, 2025 00:30
@Mantisus Mantisus requested a review from Pijukatel August 8, 2025 00:35
@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests August 8, 2025 00:35 — with GitHub Actions Failure
@Mantisus Mantisus requested a review from janbuchar August 8, 2025 00:35
@Mantisus Mantisus marked this pull request as ready for review August 8, 2025 00:35
@Mantisus Mantisus requested a review from Copilot August 8, 2025 00:36
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the minimum Python version requirement from 3.9 to 3.10 across the project configuration and CI workflows.

  • Updates project metadata to require Python 3.10+
  • Removes Python 3.9 from CI/CD pipeline testing
  • Utilizes Python 3.10+ features in the codebase

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
pyproject.toml Updates minimum Python version requirement and removes Python 3.9 classifier
.github/workflows/run_code_checks.yaml Removes Python 3.9 from testing matrix
.github/workflows/release.yaml Removes Python 3.9 from release workflow testing
.github/workflows/pre_release.yaml Removes Python 3.9 from pre-release workflow testing
src/apify_client/clients/resource_clients/log.py Adds strict=False parameter to zip() call

Copy link
Contributor

@Pijukatel Pijukatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest to wait with this.
See:
#448

Copy link
Contributor

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We consider dropping support for Python version a BC, so this is gonna be part of Client v2 (together with the switch to Impit). I thought I would just restore the branch from #432.

@Mantisus Mantisus had a problem deploying to fork-pr-integration-tests August 12, 2025 17:24 — with GitHub Actions Failure
@vdusek vdusek closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants